feat: Update model resolution logic for LLM agents #321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_791915369
branch
3 times, most recently
from
c2f2a5a to
b0c0e76
Compare
This change refactors the model resolution logic within the LlmAgent to utilize the LlmRegistry for looking up model instances by name. It also introduces a canonicalModel() method to ensure a BaseLlm instance is consistently available, simplifying model access in flows. PiperOrigin-RevId: 792361836
copybara-service
bot
force-pushed
the
test_791915369
branch
from
b0c0e76 to
4fc83f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Update model resolution logic for LLM agents
This change refactors the model resolution logic within the LlmAgent to utilize the LlmRegistry for looking up model instances by name. It also introduces a canonicalModel() method to ensure a BaseLlm instance is consistently available, simplifying model access in flows.